Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Remove repeated URL parsing #270

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: Remove repeated URL parsing #270

wants to merge 1 commit into from

Conversation

marvinhagemeister
Copy link
Contributor

Fresh alread stores a parsed URL instance under ctx.url. No need to construct that yourself.

crowlKats
crowlKats reviewed Mar 12, 2024
View reviewed changes
Copy link
Collaborator

@crowlKats crowlKats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice cleanup, though would be better not to create the reqUrl variable anymore.

@iuioiua iuioiua mentioned this pull request May 14, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request May 20, 2024
@iuioiua @lucacasonato
chore: remove repeated URL parsing (#510)
0ea1d6b 
Replaces #270

---------

Co-authored-by: Luca Casonato <hello@lcas.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crowlKats crowlKats crowlKats left review comments

@lucacasonato lucacasonato Awaiting requested review from lucacasonato

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marvinhagemeister @crowlKats