Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds keywords to work items #401

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

CoffeeVector
Copy link

feat #398
I think this would be a good addition to the standard. I think it's not uncommon for people to like putting keywords into their resume.

schema.json Outdated
"additionalItems": false,
"items": {
"type": "string",
"description": "e.g. python, leadership, public speaking"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe give only one example on this line, to make clear that each array item contains only one skill, not one long string containing multiple skills. Just for clarity.

schema.json Outdated
},
"keywords": {
"type": "array",
"description": "Specify technologies or skills used, e.g. HTML, CSS, Javascript",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And maybe just remove the examples from this line, to keep it consistent with the keywords in other sections (Skills, Interests, Projects), see https://github.com/jsonresume/resume-schema/blob/v1.0.0/schema.json.

@pflorek
Copy link

pflorek commented May 16, 2021

closes #420

@anthonyjdella
Copy link

Isn't this basically what was already proposed in #409

@peternowee
Copy link

Isn't this basically what was already proposed in #409

Yes, you are right, though this one here (#401) was first and I think is also a bit better because it names the array "keywords", which is consistent with existing use of keywords in other resume sections (Skills, Interests, Projects).

@jacrys
Copy link

jacrys commented Oct 1, 2021

Yes, I missed this in my search for existing PRs, likely because my mental space was in "skills" mode so horse blinders and all that.

@anthonyjdella
Copy link

Isn't this basically what was already proposed in #409

Yes, you are right, though this one here (#401) was first and I think is also a bit better because it names the array "keywords", which is consistent with existing use of keywords in other resume sections (Skills, Interests, Projects).

Ah I didn't realize this one was first, my bad.

@nightscape
Copy link

Anything preventing this from moving forward?

@CoffeeVector
Copy link
Author

Oh my bad. I've sinced haven't needed to update my resume in a while, so I didn't notice any activity on this. I've made the changes @peternowee suggested if you still want this change.

Copy link

@peternowee peternowee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, looks perfect to me now!

@nightscape
Copy link

I think someone would need to trigger the workflow, right?
@pflorek @peternowee

Copy link

@pflorek pflorek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@pflorek
Copy link

pflorek commented Feb 7, 2023

I think someone would need to trigger the workflow, right? @pflorek @peternowee

I'm not a maintainer, who is in charge?

@pflorek
Copy link

pflorek commented Feb 7, 2023

@evanplaice @thomasdavis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants