-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adds keywords to work items #401
base: master
Are you sure you want to change the base?
Conversation
schema.json
Outdated
"additionalItems": false, | ||
"items": { | ||
"type": "string", | ||
"description": "e.g. python, leadership, public speaking" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe give only one example on this line, to make clear that each array item contains only one skill, not one long string containing multiple skills. Just for clarity.
schema.json
Outdated
}, | ||
"keywords": { | ||
"type": "array", | ||
"description": "Specify technologies or skills used, e.g. HTML, CSS, Javascript", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And maybe just remove the examples from this line, to keep it consistent with the keywords
in other sections (Skills, Interests, Projects), see https://github.com/jsonresume/resume-schema/blob/v1.0.0/schema.json.
closes #420 |
Isn't this basically what was already proposed in #409 |
Yes, I missed this in my search for existing PRs, likely because my mental space was in "skills" mode so horse blinders and all that. |
Ah I didn't realize this one was first, my bad. |
Anything preventing this from moving forward? |
393406f
to
e3a137a
Compare
Oh my bad. I've sinced haven't needed to update my resume in a while, so I didn't notice any activity on this. I've made the changes @peternowee suggested if you still want this change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, looks perfect to me now!
I think someone would need to trigger the workflow, right? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
I'm not a maintainer, who is in charge? |
feat #398
I think this would be a good addition to the standard. I think it's not uncommon for people to like putting keywords into their resume.