Update to Elm 0.19.1; fix tests #46
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few tests were not running when I updated to Elm 0.19.1. I didn't check if they were also broken in the previous version. I was mainly changing how Encode.list works I think. There were two tests that depend on comparing Json.Encode.Value which now show as and cannot be compared. I have commented these out, maybe you can think of a way to rewrite them, I have not yet given that much thought.
In addition my editor shows me elm-analyse errors, so I removed some code (and a few debug log comments) and rewrote a couple of bits to silence those warnings. One remaining error is for
ValidationOptionswhich has only one boolean value, analyse wants to get rid of the object but I left it in.