Extract propertyDependencies
#1506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdesrosiers
reviewed
May 10, 2024
Co-authored-by: Jason Desrosiers <jdesrosi@gmail.com>
Co-authored-by: Jason Desrosiers <jdesrosi@gmail.com>
|
Added an ADR per the changes in the template PR and #1443 (comment) |
jdesrosiers
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a second attempt at #1450. Rather than start from scratch, I build upon that because I wanted to keep the build changes that @jdesrosiers made.
The idea here is that the proposal document is something that the users will be concerned about, including both a summary of why the proposal is being made and the specific changes to official documents.
There will also a be separate "decision" document (not yet added), which may just be an ADR, that goes through why this solution is being proposed, including pro/con analysis of any alternative designs. We'll continue discussing in #1443 about what this secondary document looks like.