Regex editorial improvements, and permit "." #1470
Conversation
Consistently "quote" examples.
Split complemented simple and range class examples.
Improve "(" .. ")" grouping example.
jsonschema-core.md
Outdated
| - simple character classes ("[abc]"), range character classes ("[a-z]"); | ||
| - complemented simple character classes ("[^abc]"), | ||
| complemented range character classes ("[^a-z]"); | ||
| - simple quantifiers: "." (any character except line terminator), |
There was a problem hiding this comment.
. is not a quantifier, doesn't belong here. I think it should be up just after literal characters / before character classes.
There was a problem hiding this comment.
Ok, how about the following, moved as you suggest?
- simple atoms: "." (any character except line terminator);
|
We've discussed this before, and I think it may be worth bringing it up again. IETF has now published https://datatracker.ietf.org/doc/rfc9485/ to support interoperable regex in JSON Path. It may be wise to reconsider this in place of ECMA. Doing so would mean being able to remove all of these restrictions. |
|
@gregsdennis I feel like I'm inclined to agree with this person's opinion that iregexp is not a good fit for JSON Schema - though I have not kept up with any changes since 2022 that may have changed that situation. |
|
Yeah, I hear you. But finding interoperable regex support has been a thorn in our side for a long time. It really has no bearing on this PR, though. |
|
I've added 3 commits addressing various review feedback above. |
jsonschema-core.md
Outdated
| - complemented simple character classes (`[^abc]`), | ||
| complemented range character classes (`[^a-z]`); |
There was a problem hiding this comment.
This feels weird to me. Either make them separate bullets
| - complemented simple character classes (`[^abc]`), | |
| complemented range character classes (`[^a-z]`); | |
| - complemented simple character classes (`[^abc]`); | |
| - complemented range character classes (`[^a-z]`); |
or combine them
| - complemented simple character classes (`[^abc]`), | |
| complemented range character classes (`[^a-z]`); | |
| - complemented simple (`[^abc]`) and range (`[^a-z]`) character classes; |
There was a problem hiding this comment.
I have made the first suggestion; keeping the multi-word terms together before the example makes it easier to search for those terms. I.e, a (cross-)reference to the term "complemented range" is easier to find that way.
See commit ac0a13c
Add "." to the permitted simple atoms, for issue #1469.
Consistently format the regex examples.