Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm audit and packages upgrade #1545

Merged
merged 10 commits into from
Apr 16, 2024

Conversation

germanbisurgi
Copy link
Collaborator

Q A
Is backward-compatible? ✔️
Tests pass? ✔️

@schmunk42
Copy link
Collaborator

@germanbisurgi
Copy link
Collaborator Author

germanbisurgi commented Apr 15, 2024

Dependency incompatibilities between packages are resolved.

Most packages were upgraded to address vulnerabilities.

The autocomplete test was failing due to slow loading CDN package, sometimes up to 40 seconds. I put the static files in a static folder in test for that and after that worked as expected.

I had to change the codeceptjs command since the options muss be passed after the main command

Eslint config had to be updated because the new version introduced new rules that were not enforced before. Also a webpack plugin is used instead of a loader.

Small code refactoring were made to fix some linting errors (var to let, and property name with same value name shorthand)

@germanbisurgi germanbisurgi merged commit ce55cda into json-editor:master Apr 16, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants