Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix describedby #1344

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix describedby #1344

wants to merge 1 commit into from

Conversation

Djuvl
Copy link

@Djuvl Djuvl commented Jun 2, 2023

modified: src/validator.js src/describedby.js

Q A
Is bugfix? ✔️
New feature?
Is backward-compatible?
Tests pass? ✔️
Fixed issues comma-separated list of tickets # fixed by the PR, if any
Updated README/docs?
Added CHANGELOG entry?

Fixes #1316

modified:   src/validator.js
Copy link
Collaborator

@germanbisurgi germanbisurgi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Djuvl At line 723 the this.getWatchedFieldValues() method does not exist. If this line is left unchanged then the fix works.

@Djuvl
Copy link
Author

Djuvl commented Jul 12, 2023

The old code cause a null error, so i use the this.getWatchedFieldValues() method. I find the method in the master branch.

json-editor/src/editor.js

Lines 471 to 473 in e89c43d

getWatchedFieldValues () {
return this.watched_values
}

ok, the method is not exist on the validator object. But simply left the old code unchanged is not a good way, as it will always get a undifined. The validator need to get the watched field realtime value, so the value can be pass to the ref template. I did not find a way to get the value in that function. At least the path to the schame is needed, so the watched value can be got from the jsoneditor object, i think. Is there any idea?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The describedy editor is broken
2 participants