-
Notifications
You must be signed in to change notification settings - Fork 830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clarify intent of links member #1691
base: gh-pages
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks better
@jelhan someone raised a good point in my Laravel JSON:API repo - can FYI I'm in support of this clarification - I've always found it confusing as to whether you're allowed to customise the |
No. Profiles can only define document members and processing rules that are reserved for implementors. The An extension can define additional members for the |
Ah yes, sorry I think I meant profiles or extensions. Agree with what you've written. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO it could be back ported in v1.1
There has been many confusion about the intent of the links member. People tried using it for links not pointing to other JSON:API documents. Such as related files, related resources represented in different formats or other representations of the same resource in other formats. This PR tries to clarify the intent of
links
member and pointing readers to alternative ways solving their use case.Open questions:
Closes #1684 #1678