Highlight currently viewed section in spec sidebar #1384 #1474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auvipy
approved these changes
May 10, 2020
|
@auvipy Who can merge this into master? |
|
@NageswaraRaoMaridu thanks for your PR, and sorry to take so long to review it! I just tried this out and find that it gets us only part of the way to the goal of #1384. While it does highlight sections when they are clicked, it does not change the highlight as you scroll (thus the highlighting feel broken if it's not kept current). Are you up for that challenge as well? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reading json api specification, it's getting difficult to realize in which section we are right now. This pull request highlight the side navigation links when user clicks on them.