Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mark application/octet-stream as compressible #163

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

greggman
Copy link

didn't see anything in iana rfc about this not being compressible.

I see a few extensions that are probably already compressed like distz and dmg but overall most things sent as application/octet-stream would benefit from compression it seems.

Copy link
Contributor

@dougwilson dougwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

most things sent as application/octet-stream would benefit from compression it

It's possible. Can you provide data on this? Perhaps a definition of "most" like what % of data transferred under this is compressible and by how much? Or at least something concrete to make the decision on?

@vchirikov
Copy link

Hi @dougwilson .
I ran into this issue because I'am using Blazor (wasm, dll extension) on gh-pages and it uses this library.
So here information about gz / br / uncompressed for Blazor

Filename(without extension) Original size (.dll) gzip (.gz) brotli (.br)
Blog 77824 34191 29487
BrowserInterop 149504 54428 41707
Markdig 401408 153788 123906
Microsoft.AspNetCore.Components 110592 48191 41705
Microsoft.AspNetCore.Components.Web 19968 8322 6520
Microsoft.AspNetCore.Components.WebAssembly 43520 20586 17876
Microsoft.Bcl.AsyncInterfaces 5120 1957 1695
Microsoft.Extensions.Configuration.Abstractions 10752 4475 3916
Microsoft.Extensions.Configuration 12288 5776 4998
Microsoft.Extensions.Configuration.Json 10240 4790 4150
Microsoft.Extensions.DependencyInjection.Abstractions 20992 7863 6686
Microsoft.Extensions.DependencyInjection 62464 28253 24166
Microsoft.Extensions.Logging.Abstractions 37376 16362 13462
Microsoft.Extensions.Logging 19968 9466 8296
Microsoft.Extensions.Options 40960 17091 13627
Microsoft.Extensions.Primitives 25600 11258 9776
Microsoft.JSInterop 32256 14463 12960
Microsoft.JSInterop.WebAssembly 6656 2972 2603
mscorlib 1808896 693895 577881
SharpYaml 217088 88250 75471
System.Core 312832 123639 104961
System 264192 114576 98052
System.Net.Http 99328 44859 38582
System.Net.Http.WebAssemblyHttpHandler 21504 9779 8533
System.Runtime.CompilerServices.Unsafe 2560 920 774
System.Text.Encodings.Web 25600 9155 8085
System.Text.Json 217088 85301 71869
Toolbelt.Blazor.HeadElement.Abstractions 8192 3304 2863
Toolbelt.Blazor.HeadElement 9728 4142 3565
Toolbelt.Blazor.HeadElement.Services 23040 9026 7623
WebAssembly.Bindings 19456 9134 8058

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants