Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update minimatch version #2952

Closed
adamreisnz opened this issue Jun 18, 2016 · 37 comments
Closed

Update minimatch version #2952

adamreisnz opened this issue Jun 18, 2016 · 37 comments

Comments

@adamreisnz
Copy link

adamreisnz commented Jun 18, 2016

Could you please update your package to use the latest version of minimatch?
The version currently used by jshint is throwing deprecation warnings:

npm WARN deprecated minimatch@2.0.10: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
@SOSANA
Copy link

SOSANA commented Jun 22, 2016

(crickets)

@scottjason
Copy link

+1

1 similar comment
@biancama
Copy link

+1

@jugglinmike
Copy link
Member

Thanks for the report! There is a pull request available here: gh-2953.

I can see that that many of you want this change; please have patience as
responsibly updating dependencies requires careful review of change logs.

@jugglinmike
Copy link
Member

gh-2953 is now merged. I'd like to get a few more bug fixes in for the next
patch release, but this should be available on npm within the week.

@afried101
Copy link

Should I be able to get the new version? Built a new PC last evening, can't get cordova working at all. I get this warning (tried updating "npm update -g minimatch@3.0.2" but that didn't work. I have uninstalled/reinstalled NPM and node. When I try to install cordova, I get the minimatch error, and then a bunch of garbage for the install results. It then will not let me use cordova commands:

PM> npm update -g minimatch@3.0.2
PM> npm install -g cordova
npm : npm WARN deprecated minimatch@2.0.10: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
At line:1 char:1

  • npm install -g cordova
  • - CategoryInfo          : NotSpecified: (npm WARN deprec...egExp DoS issue:String) [], RemoteException
    - FullyQualifiedErrorId : NativeCommandError
    
    

npm
WARN

package.json
glob@7.0.4 No README data

C:\Users\afriedman\AppData\Roaming\npm\cordova -> C:\Users\afriedman\AppData\Roaming\npm\node_modules\cordova\bin\cordova
cordova@6.2.0 C:\Users\afriedman\AppData\Roaming\npm\node_modules\cordova
Γö£ΓöÇΓöÇ underscore@1.7.0
Γö£ΓöÇΓöÇ q@1.0.1
Γö£ΓöÇΓöÇ nopt@3.0.1 (abbrev@1.0.9)
Γö£ΓöÇΓöÇ update-notifier@0.5.0 (is-npm@1.0.0, string-length@1.0.1, chalk@1.1.3, semver-diff@2.1.0, repeating@1.1.3, configstore@1.4.0, latest-version@1.0.1)
Γö£ΓöÇΓöÇ insight@0.8.2 (object-assign@4.1.0, lodash.debounce@3.1.1, node-uuid@1.4.7, chalk@1.1.3, async@1.5.2, os-name@1.0.3, configstore@1.4.0, tough-cookie@2.2.2, request@2.72.0, inquirer@0.10.1)
Γö£ΓöÇΓöÇ cordova-common@1.3.0 (cordova-registry-mapper@1.1.15, ansi@0.3.1, semver@5.2.0, osenv@0.1.3, underscore@1.8.3, q@1.4.1, unorm@1.4.1, minimatch@3.0.2, glob@5.0.15, shelljs@0.5.3, bplist-parser@0.1.1, elementtree@0.1.6, plist@1.2.0)
ΓööΓöÇΓöÇ cordova-lib@6.2.0 (valid-identifier@0.0.1, opener@1.4.1, cordova-registry-mapper@1.1.15, properties-parser@0.2.3, nopt@3.0.6, unorm@1.3.3, shelljs@0.3.0, semver@4.3.6, dep-graph@1.1.0, glob@5.0.15, init-package-json@1.9.4, xcode@0.8.8, elementtree@0.1.6, cordova-serve@1.0.0, request@2.47.0, tar@1.0.2, cordova-fetch@1.0.0, aliasify@1.9.0, plist@1.2.0, cordova-js@4.1.4, cordova-app-hello-world@3.10.0, npm@2.15.8)

PM> cordova create testapp com.test.testapp testapp
cordova : The term 'cordova' is not recognized as the name of a cmdlet, function, script file, or operable program. Check the spelling of the name, or if a path was included, verify that the path is correct
and try again.
At line:1 char:1

  • cordova create testapp com.test.testapp testapp
  • - CategoryInfo          : ObjectNotFound: (cordova:String) [], CommandNotFoundException
    - FullyQualifiedErrorId : CommandNotFoundException
    
    

PM>

Trying to get to the bottom of this, hoping maybe this is the cause? I don't honestly think it's a cordova issue, but could be wrong.

@jugglinmike
Copy link
Member

@afried101 please refer to my previous comment--this is not yet published to npm.

I am surprised that a warning is causing your build to fail, though. That wasn't my understanding of how deprecation works in npm. Locally, I am still able to install JSHint without error (via npm install jshint, using Node 6.2.0 and npm 3.8.9

@razn12
Copy link

razn12 commented Jun 30, 2016

npm WARN deprecated minimatch@2.0.10: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue

what should i do??? any suggestion

@jugglinmike
Copy link
Member

I would like to help, but this is not enough information. Besides the message
printed to the terminal, can you please explain the effect this is having on
your work flow? Also please include the version of Node.js and npm you are
using.

@afried101
Copy link

Mike, my issue was not NPM/Node/Minimatch. I don't know what it was - the project was on a server - all that changed was a fresh VS15 install... But, I created a new project through the IDE instead of NPM, and I have my cordova command back in npm and all is well. Can't say what fixed it other than "create a new project through the IDE."

@francoaban
Copy link

@codeuniquely
Copy link

Node Built output today - with latest version of repo...

npm WARN deprecated minimatch@2.0.10: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue

@CarolinaKadix
Copy link

try this
6a65a5fc-4b0a-11e6-88f6-a8b4dfcaa3a1

@ramsaikumar
Copy link

tq CarolinaKadix it worked perfectly. no issues till now

@caiodev
Copy link

caiodev commented Aug 2, 2016

Thank you so much CarolinaKadix, you helped me a lot, I use Ubuntu Mate and your tip leaded me to solve this problem.

@erhanyasar
Copy link

erhanyasar commented Aug 11, 2016

I just started to take the same errors and my cordova doesn't build anymore even I tried to re-install. I tried the @CarolinaKadix method with my Mac with "sudo" prefix hence, it all went the same till getting the same error with the screenshot below. Any opinion??

Update: I deleted all the "node_modules" files and uninstalled the npm & node 0.o then re-installed them hence still the same issue continues and it says it's a path problem even I fixed permissions issues again with npm.

screen shot 2016-08-11 at 14 46 57

@adh148
Copy link

adh148 commented Aug 11, 2016

Having the same exact issue at @erhanyasar

@pixelcanvas
Copy link

npm install -g minimatch@3.0.2

@adh148
Copy link

adh148 commented Aug 11, 2016

@pixelcanvas that hasn't worked either

@erhanyasar
Copy link

Yes already mentioned not working the same way 😕

@erhanyasar
Copy link

I talked with npm on twitter and they replied it will be updated by today. Anyway today again I uninstalled both "node" and "npm" from both terminal and the folders on "usr/local/lib" & "usr/local/include" and users. Then tried "severe uninstall" incase. And tried to install node and npm again with mini match updated. Then it worked even says the same error once but it loads. @pixelcanvas @Landing-eagle hope you try and & succeed the same.

@pixelcanvas
Copy link

@erhanyasar Actually it worked for me :-)

@NormanID
Copy link

he installed mini match in directory npm \ npm-modules \ minimatch \ they just need the file transferred direct to match npm\

@andig
Copy link

andig commented Aug 13, 2016

can you please explain the effect this is having on your work flow?

@jugglinmike the minimatch version in cli has a security issue. If possible please upgrade cli to a current version- that will also upgrade minimatch imho.

chadxz added a commit to asterisk/node-ari-client that referenced this issue Aug 14, 2016
This patch updates all outdated development dependencies, but does
not upgrade the two outdated production dependencies.

- swagger-client, which is currently pinned at 2.1.17 due to a
breaking change that is difficult to address (see #47 for details).

- bluebird, which currently has a major version upgrade available
that includes breaking changes. See
http://bluebirdjs.com/docs/new-in-bluebird-3.html for details.
These are workable changes for node-ari-client, but we expose
bluebird Promises on our public API, so updating this would require
a major version bump.

For changes in the development dependencies, see the following
changelog entries:

- grunt: http://gruntjs.com/blog/2016-04-04-grunt-1.0.0-released
- async: https://github.com/caolan/async/blob/master/CHANGELOG.md
- mocha: https://github.com/mochajs/mocha/blob/master/CHANGELOG.md
- mustache: https://github.com/janl/mustache.js/blob/master/CHANGELOG.md
- portfinder: http-party/node-portfinder#20

No details regarding the major version bump of hock could be found.

There are still some npm install warnings even after updating these
dependencies:

- jshint is throwing a warning about minimatch needing an upgrade.
The fix for this is already in the jshint master branch, but no
npm version has been cut for it yet. For additional details, see
jshint/jshint#2952

- jsdoc is throwing warnings about minimatch needing an upgrade,
wrench being completely deprecated in favor of another library,
and the marked package not being meant to be installed as a dep.
Upon investigation, it seems that the jsdoc package has actually
been abandoned, so we need to start thinking about migrating away
from it. Ticket #55 has been opened to investigate this.

- grunt has a warning about coffee-script not being meant to be
installed as a dep. This isn't really worth looking into, as we
are gradually moving away from grunt anyway.
chadxz added a commit to asterisk/node-ari-client that referenced this issue Aug 14, 2016
This patch updates all outdated development dependencies, but does
not upgrade the two outdated production dependencies.

- swagger-client, which is currently pinned at 2.1.17 due to a
breaking change that is difficult to address (see #47 for details).

- bluebird, which currently has a major version upgrade available
that includes breaking changes. See
http://bluebirdjs.com/docs/new-in-bluebird-3.html for details.
These are workable changes for node-ari-client, but we expose
bluebird Promises on our public API, so updating this would require
a major version bump.

For changes in the development dependencies, see the following
changelog entries:

- grunt: http://gruntjs.com/blog/2016-04-04-grunt-1.0.0-released
- async: https://github.com/caolan/async/blob/master/CHANGELOG.md
- mocha: https://github.com/mochajs/mocha/blob/master/CHANGELOG.md
- mustache: https://github.com/janl/mustache.js/blob/master/CHANGELOG.md
- portfinder: http-party/node-portfinder#20

No details regarding the major version bump of hock could be found,
but it had a substantial change to its public api. Namely, it does not
handle any of the actual http server stuff for you anymore. Changes
are included in this PR to adapt the tests to this new api.

There are still some npm install warnings even after updating these
dependencies:

- jshint is throwing a warning about minimatch needing an upgrade.
The fix for this is already in the jshint master branch, but no
npm version has been cut for it yet. For additional details, see
jshint/jshint#2952

- jsdoc is throwing warnings about minimatch needing an upgrade,
wrench being completely deprecated in favor of another library,
and the marked package not being meant to be installed as a dep.
Upon investigation, it seems that the jsdoc package has actually
been abandoned, so we need to start thinking about migrating away
from it. Ticket #55 has been opened to investigate this.

- grunt has a warning about coffee-script not being meant to be
installed as a dep. This isn't really worth looking into, as we
are gradually moving away from grunt anyway.
@jugglinmike
Copy link
Member

We just released JSHint version 2.9.3, which contains an updated version of the "minimatch" library.

@slashkite
Copy link

I still have this issue after a clean installation. Any recommendations? Thanks in advance.

@CarolinaKadix
Copy link

Hi, @slashkite
Did you clean it, did a fresh install, and updated the minimatch for example?

@slashkite
Copy link

slashkite commented Dec 22, 2016

@CarolinaKadix thanks for the info.

i have minimatch on 3.0.3 and grunt-sync 0.6.2 generally.

When installing sails globally, it takes grunt-sync 0.5.2, which uses minimatch 2.0.10.

├─┬ grunt-sync@0.5.2
│ ├─┬ glob@4.5.3
│ │ └── minimatch@2.0.10
│ ├── md5-file@2.0.7
│ └── promised-io@0.3.3

Am I doing something wrong?

@tkhuynh
Copy link

tkhuynh commented Jan 13, 2017

It's so weird that I have that warning
npm WARN deprecated minimatch@2.0.10: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue /usr/local/bin/ng -> /usr/local/lib/node_modules/angular-cli/bin/ng
Even though
➜ ~ npm -v minimatch
4.1.1

/usr/local/lib
├─┬ angular-cli@1.0.0-beta.25.5
│ ├── minimatch@3.0.3 
│ ├─┬ remap-istanbul@0.6.4
│ │ └─┬ istanbul@0.4.3
│ │   └─┬ fileset@0.2.1
│ │     └── minimatch@2.0.10 
│ └─┬ webpack-dev-server@2.2.0-rc.0
│   └─┬ chokidar@1.6.1
│     └─┬ fsevents@1.0.17
│       └─┬ node-pre-gyp@0.6.32
│         └─┬ rimraf@2.5.4
│           └─┬ glob@7.1.1
│             └── minimatch@3.0.3 

@kenany
Copy link

kenany commented Jan 13, 2017

@tkhuynh Do note that npm -v minimatch will print the version of npm you have installed.

@tkhuynh
Copy link

tkhuynh commented Jan 13, 2017

@kenany any suggestion to bypass that warning?

@slashkite
Copy link

I think it's because of the old fileset version

@tkhuynh
Copy link

tkhuynh commented Jan 13, 2017

@slashkite any ways to update it?
I even did this before I install angular-cli, I still get that warning

sudo npm install -g minimatch@3.0.2
/usr/local/lib
└── minimatch@3.0.2 

@kenany
Copy link

kenany commented Jan 13, 2017

@tkhuynh Installing minimatch globally won't help. You gotta get fileset's dependency on minimatch updated and then ensure that it gets propagated up the dep tree.

@consistime
Copy link

same with me, doesnt fix at all

@NormanID
Copy link

npm install -g minimatch@latest

@fmarrot
Copy link

fmarrot commented Apr 6, 2017

Thanks CarolinaKadix it worked perfectly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests