Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dev dependencies #56

Merged
merged 1 commit into from
Aug 17, 2016
Merged

Update dev dependencies #56

merged 1 commit into from
Aug 17, 2016

Conversation

chadxz
Copy link
Contributor

@chadxz chadxz commented Aug 14, 2016

This patch updates all outdated development dependencies, but does
not upgrade the two outdated production dependencies.

For changes in the development dependencies, see the following
changelog entries:

No details regarding the major version bump of hock could be found,
but it had a substantial change to its public api. Namely, it does not
handle any of the actual http server stuff for you anymore. Changes
are included in this PR to adapt the tests to this new api.

There are still some npm install warnings even after updating these
dependencies:

  • jshint is throwing a warning about minimatch needing an upgrade.
    The fix for this is already in the jshint master branch, but no
    npm version has been cut for it yet. For additional details, see
    Update minimatch version jshint/jshint#2952
  • jsdoc is throwing warnings about minimatch needing an upgrade,
    wrench being completely deprecated in favor of another library,
    and the marked package not being meant to be installed as a dep.
    Upon investigation, it seems that the jsdoc package has actually
    been abandoned, so we need to start thinking about migrating away
    from it. Ticket replace jsdoc with a non-abandoned project #55 has been opened to investigate this.
  • grunt has a warning about coffee-script not being meant to be
    installed as a dep. This isn't really worth looking into, as we
    are gradually moving away from grunt anyway.

@chadxz
Copy link
Contributor Author

chadxz commented Aug 14, 2016

this is gonna need some additional work. tests are failing... will have to follow up later, as i'm out of time for today. I think the problem is related to either hock or portfinder.

This patch updates all outdated development dependencies, but does
not upgrade the two outdated production dependencies.

- swagger-client, which is currently pinned at 2.1.17 due to a
breaking change that is difficult to address (see #47 for details).

- bluebird, which currently has a major version upgrade available
that includes breaking changes. See
http://bluebirdjs.com/docs/new-in-bluebird-3.html for details.
These are workable changes for node-ari-client, but we expose
bluebird Promises on our public API, so updating this would require
a major version bump.

For changes in the development dependencies, see the following
changelog entries:

- grunt: http://gruntjs.com/blog/2016-04-04-grunt-1.0.0-released
- async: https://github.com/caolan/async/blob/master/CHANGELOG.md
- mocha: https://github.com/mochajs/mocha/blob/master/CHANGELOG.md
- mustache: https://github.com/janl/mustache.js/blob/master/CHANGELOG.md
- portfinder: http-party/node-portfinder#20

No details regarding the major version bump of hock could be found,
but it had a substantial change to its public api. Namely, it does not
handle any of the actual http server stuff for you anymore. Changes
are included in this PR to adapt the tests to this new api.

There are still some npm install warnings even after updating these
dependencies:

- jshint is throwing a warning about minimatch needing an upgrade.
The fix for this is already in the jshint master branch, but no
npm version has been cut for it yet. For additional details, see
jshint/jshint#2952

- jsdoc is throwing warnings about minimatch needing an upgrade,
wrench being completely deprecated in favor of another library,
and the marked package not being meant to be installed as a dep.
Upon investigation, it seems that the jsdoc package has actually
been abandoned, so we need to start thinking about migrating away
from it. Ticket #55 has been opened to investigate this.

- grunt has a warning about coffee-script not being meant to be
installed as a dep. This isn't really worth looking into, as we
are gradually moving away from grunt anyway.
@chadxz
Copy link
Contributor Author

chadxz commented Aug 14, 2016

got this fixed and ready to merge.

@chadxz
Copy link
Contributor Author

chadxz commented Aug 17, 2016

ping, can someone take a look

@danjenkins
Copy link
Contributor

👍

@chadxz chadxz merged commit 50aa39c into master Aug 17, 2016
@chadxz chadxz deleted the update-dependencies branch August 17, 2016 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants