Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the getSetCookie method of Headers #3694

Merged
merged 2 commits into from
May 26, 2024

Conversation

ushiboy
Copy link
Contributor

@ushiboy ushiboy commented Mar 19, 2024

I've implemented the getSetCookie method of Headers. The HeaderList data structure has been changed accordingly.

See here for the specification of the getSetCookie method.
https://developer.mozilla.org/en-US/docs/Web/API/Headers/getSetCookie

With this fix, the header-setcookie.any.html test is resolved except for a failure due to Response not being implemented.

before

  1) web-platform-tests
       fetch/api/headers
         header-setcookie.any.html:
     18/24 errors in test:

Failed in "Headers iterator does not combine set-cookie headers":
assert_equals: Array length is not equal expected 2 but got 1
...

after

  1) web-platform-tests
       fetch/api/headers
         header-setcookie.any.html:
     1/24 errors in test:

Failed in "Set-Cookie is a forbidden response header"
Response is not defined

@ushiboy
Copy link
Contributor Author

ushiboy commented Mar 20, 2024

Why are CI tests for latest failing?

The overwritten-customElements-global.html is set up to expect the test to fail, but since node.js v21.7, the test seems to succeed.

This can be resolved by setting to-run.yaml to overwritten-customElements-global.html: [flaky, Unknown], but I cannot determine if that should be included in this PR.

@Stadly

This comment was marked as spam.

@domenic domenic force-pushed the feature/headers-get-set-cookie branch from d287809 to 50e1d41 Compare May 26, 2024 08:21
@domenic domenic self-assigned this May 26, 2024
@domenic domenic merged commit a343932 into jsdom:main May 26, 2024
5 checks passed
@ushiboy ushiboy deleted the feature/headers-get-set-cookie branch May 26, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants