Trigger selectionchange event on document when selection changes (small change - 2 files) #3676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotr-oles
changed the title
|
There is a timeout on node-canvas - I'm not sure if it's just flaky test |
|
@domenic could you take a look? :) |
|
Based on https://jsbin.com/qiyexuxoro/edit?html,output, the test does not seem to be valid. (Or at least does not match Firefox and Chrome behaviors.) |
|
One guess is that the spec says to schedule the event by queuing a task, whereas this fires it immediately. In jsdom we often emulate this sort of task queuing by doing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to test my contenteditable component that relies on
selectionchangeevents. When debugging why my tests doesn't reflect browser behaviour, I found this TODO:https://github.com/jsdom/jsdom/blob/main/lib/jsdom/living/selection/Selection-impl.js#L335
This PR addresses that TODO by triggering
selectionchangeevent ondocumentas stated in the spec. I added missing tests as well.