Update nwsapi and add a test for getComputedStyle #3609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Blocked by dperini/nwsapi#98 |
alonidiom
force-pushed
the
master
branch
2 times, most recently
from
8b7212f
to
0938de3
Compare
As far as I understand it, the pull request has been merged and the changes are part of nwsapi 2.2.8 which was released a few hours ago. |
|
I've rebased your change on main, which has nwsapi 2.2.10. But it appears the test is failing, so nwsapi is still buggy... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempting to solve #3607 by updating the nwsapi dependency.