testing: add code coverage #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've added a separate commit which adds an HTML coverage report, with npm scripts to start a static server and open the report therein. |
Closed
sandersn
approved these changes
Dec 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't needed for that npm release, but thought I'd file now as a PR to make sure folks were happy with this approach.
FWIW, there are issues filed of pegjs for code coverage (just added) and for a prerequisite of this, source maps, but I think it is still worth adding
nychere now in this PR, as it still allows us to detect coverage for the non-PEG files (and if someone really wanted, they could dig into the compiled PEG file so as to compare manually back to PEG source).Once this may be merged, I have a couple coverage tests/changes we can add to improve coverage.