Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security Fix for Prototype Pollution #579

Merged

Conversation

ready-research
Copy link
Contributor

@ready-research ready-research commented Sep 5, 2021

The previously patched fix is fixing only deepMixIn(), the vulnerability is still reproducible by using other methods like deepFillIn and set.

Fixing the issues in set() and deepFillIn()

Reported in (Can you please validate these?)
https://www.huntr.dev/bounties/0391c0aa-a145-42bc-b402-02da110044f7/
https://www.huntr.dev/bounties/432bf9f6-23e3-4b0a-97eb-54f2a9d59afa/

  • - npm test succeeds
  • - Code coverage does not decrease (if any source code was changed)
  • - If applicable, appropriate JSDoc comments were updated in source code (if applicable)
  • - If applicable, approprate changes to js-data.io docs have been suggested ("Suggest Edits" button)

Fixing the issues in set() and deepFillIn()
@blindhacker99
Copy link

blindhacker99 commented Sep 12, 2021

I already reported both of the functions are vulnerable to prototype pollution deepFillIn() and set() about two months back on huntr
( cc: @huntr-helper). Below are the link to open issues -

@crobinson42 crobinson42 merged commit 233ec90 into js-data:master Jan 10, 2022
@ready-research
Copy link
Contributor Author

ready-research commented Jan 11, 2022

@crobinson42 Can you please validate the above huntr issues and also confirm the fixes. Thanks.

I have reported the previous prototype issue as well and commented about these in Jan 2021. See my comments in 418sec#2 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants