Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a good proposal for error handling I think, but one thing that it does is gives you the ability to configure a
go
block to automatically propagate. I don't think we should add tons of options to go functions, but this is useful enough to merit it. It should look like:Right now you'd always have to pass an empty array as the second argument. I've always found that argument redundant though since we have
spawn
. Either just use those variables directly in the go block, or use spawn to call the generator with the args, likespawn(gen(arg1, arg2))
. In the rare case that you need to use this with a new function, just dospawn((function*(x, y, z) { ... })(x, y, z))
.Removing this gives us the ability to add the above option (which I will go into more details in the errors PR), without removing hardly any functionality. What do you think?