Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release timers after closing timeout channel #111

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

gt3
Copy link

@gt3 gt3 commented Jan 1, 2017

This fix releases timers by calling clearTimeout once timeout channels close. Code changes do not affect the API directly. Refer to #110

Documentation is pending. Please comment on the issue.

@codecov-io
Copy link

codecov-io commented Jan 1, 2017

Current coverage is 94.20% (diff: 93.33%)

Merging #111 into master will increase coverage by 0.20%

@@             master       #111   diff @@
==========================================
  Files            16         16          
  Lines          1984       2019    +35   
  Methods         281        285     +4   
  Messages          0          0          
  Branches        310        316     +6   
==========================================
+ Hits           1865       1902    +37   
+ Misses          119        117     -2   
  Partials          0          0          

Powered by Codecov. Last update e4d33f7...ca20f18

gt3 referenced this pull request Jul 8, 2017
@gt3 gt3 mentioned this pull request Jul 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants