Allow custom file extensions for directory journal #1873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
comkieffer
force-pushed
the
allow-custom-file-extensions-for-directory-journal
branch
2 times, most recently
from
68590e7
to
5b5a3c4
Compare
The test previously only tested that one of the expected files was created.
comkieffer
force-pushed
the
allow-custom-file-extensions-for-directory-journal
branch
from
5b5a3c4
to
386c222
Compare
|
Thanks for building on my PR! I have not had the time to return to it since the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on #1789 (Closes issue #1289).
In short, it adds a new configuration option
extensionthat controls the extension for the files created with a folder journal.Checklist
for the same issue.