Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug-fix #798

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Bug-fix #798

wants to merge 1 commit into from

Commits on Jan 29, 2021

  1. Bug-fix 

    There is an error in line 104. (And also in line 95, but this is less important.)
The selector $("p.hidden") would find paragraphs that have a class hidden. But this is not the intention. Rather, we want to find classes that are hidden as understood by jQuery. Thus the selector should be:
$("p.hidden")

The difference ist demonstrated by the code below, with two buttons using the different selectors.

<!doctype html>
<html>
	<head>
		<meta charset="utf-8">
		<title>Demo</title>
		<style>
		a.test {
			font-weight: bold;
		}
		.box { border: solid; }
		.lookAtMe { background-color: aqua; }
		
		</style>
		<script src="jquery.js"></script>
	</head>
	<body>
		<p class="box">This paragraph will fade out when clicked. This paragraph will fade out when clicked. This paragraph will fade out when clicked. This paragraph will fade out when clicked. This paragraph will fade out when clicked. This paragraph will fade out when clicked. This paragraph will fade out when clicked. This paragraph will fade out when clicked. This paragraph will fade out when clicked. This paragraph will fade out when clicked. This paragraph will fade out when clicked. This paragraph will fade out when clicked. This paragraph will fade out when clicked. This paragraph will fade out when clicked. This paragraph will fade out when clicked. This paragraph will fade out when clicked. This paragraph will fade out when clicked. This paragraph will fade out when clicked. This paragraph will fade out when clicked. This paragraph will fade out when clicked. This paragraph will fade out when clicked. This paragraph will fade out when clicked. This paragraph will fade out when clicked. This paragraph will fade out when clicked. This paragraph will fade out when clicked. This paragraph will fade out when clicked. This paragraph will fade out when clicked. This paragraph will fade out when clicked. This paragraph will fade out when clicked.</p>
	
	
		<button id="TestButtonA">A: Show hidden paragraph and animate it.</button>
		<button id="TestButtonB">B: Show hidden paragraph and animate it.</button>
	<script>
		// Clicking on the paragraph will hide it.
		$( "p" ).on( "click", function() {
			console.log( "click" );
			$(this).hide( 800 );
		});	

		$("#TestButton").on("click", function() {
			// Fade in all hidden paragraphs; then add a style class to them (correct with animation callback)
			$( "p.hidden" ).fadeIn( 750, function() {
				// this = DOM element which has just finished being animated
				$( this ).addClass( "lookAtMe" );
			});
		});

		$("#TestButtonB").on("click", function() {
			// Fade in all hidden paragraphs; then add a style class to them (correct with animation callback)
			$( "p:hidden" ).fadeIn( 750, function() {
				// this = DOM element which has just finished being animated
				$( this ).addClass( "lookAtMe" );
			});
		});
	</script>
	</body>
</html>
    @epsilon-greater-zero
    epsilon-greater-zero committed Jan 29, 2021
    Configuration menu
    Copy the full SHA
    768474f View commit details
    Browse the repository at this point in the history