Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified _modify method to not hold | onto reference #3090

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

capak07
Copy link

@capak07 capak07 commented Apr 7, 2024

@wader
Copy link
Member

wader commented Apr 7, 2024

Trying to understand the issue. Is the problem that a reference is leaked causing a memory leak or that a reference is hold longer than needed? Is there any way to verify this works?

@emanuele6
Copy link
Member

I don't get it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

|= still holds on to a reference on the value to be modified
3 participants