builtin.jq: lpad, nwise/1, nwise/2 #2786
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpad: left pad nwise/1 replaces _nwise/1 and works on arrays and strings. nwise($n; stream) is a stream-oriented version of nwise/1, and places no limits on what may appear in the stream. It has $n as its first argument mainly in deference to limit/2. _nwise/2 is dropped.
This was referenced Jul 29, 2023
wader
reviewed
Jul 31, 2023
|
|
||
| nwise(2) | ||
| [] | ||
| [] |
There was a problem hiding this comment.
Add a negative $n test case as it seems to get stuck atm, should throw error?
There was a problem hiding this comment.
Good points. QED.
Not sure why the "Building man page...." test fails, as I don't have that problem on a Mac. Any ideas?
Add test case for nwise(0)
|
Let's discuss on the design of padding function(s) in #2033. Especially on how this is less useful on printing strings with multi-width characters in table-like format in terminals. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lpad: left pad
nwise/1 replaces _nwise/1 and works on arrays and strings. nwise($n; stream) is a stream-oriented version of nwise/1, and places no limits on what may appear in the stream. It has $n as its first argument mainly in deference to limit/2.
_nwise/2 is dropped.