-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
revert to synchronous contents manager, add separate async contents manager #186
base: main
Are you sure you want to change the base?
Conversation
2e4042d
to
c0748f5
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #186 +/- ##
==========================================
+ Coverage 34.83% 35.26% +0.43%
==========================================
Files 37 37
Lines 2589 2651 +62
Branches 458 465 +7
==========================================
+ Hits 902 935 +33
- Misses 1543 1569 +26
- Partials 144 147 +3 ☔ View full report in Codecov by Sentry. |
jupyterfs/metamanager.py
Outdated
rename = path_old_new("rename", False, sync=False) | ||
|
||
get = path_first_arg("get", True, sync=False) | ||
delete = path_first_arg("delete", False, sync=False) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't these be sync=True
for the SynceMetaManager
version to be correct?
Sorry for the delay in getting to this. I think the code looks good other than the sync=True/False being flipped, so once that is fixed I think we can merge and release. |
Let me check, the tests should definitely fail if this was done wrong |
No description provided.