Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert to synchronous contents manager, add separate async contents manager #186

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

timkpaine
Copy link
Collaborator

No description provided.

Copy link

Binder Launch a binder notebook on branch timkpaine/jupyter-fs/tkp/cm

Copy link

codecov bot commented Nov 18, 2023

Codecov Report

Attention: Patch coverage is 87.32394% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 35.26%. Comparing base (1a84b01) to head (c0748f5).

Current head c0748f5 differs from pull request most recent head fc4d3d4

Please upload reports for the commit fc4d3d4 to get more accurate results.

Files Patch % Lines
jupyterfs/pathutils.py 77.41% 4 Missing and 3 partials ⚠️
jupyterfs/extension.py 50.00% 0 Missing and 1 partial ⚠️
jupyterfs/metamanager.py 96.87% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #186      +/-   ##
==========================================
+ Coverage   34.83%   35.26%   +0.43%     
==========================================
  Files          37       37              
  Lines        2589     2651      +62     
  Branches      458      465       +7     
==========================================
+ Hits          902      935      +33     
- Misses       1543     1569      +26     
- Partials      144      147       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

rename = path_old_new("rename", False, sync=False)

get = path_first_arg("get", True, sync=False)
delete = path_first_arg("delete", False, sync=False)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't these be sync=True for the SynceMetaManager version to be correct?

@vidartf
Copy link
Contributor

vidartf commented Jan 5, 2024

Sorry for the delay in getting to this. I think the code looks good other than the sync=True/False being flipped, so once that is fixed I think we can merge and release.

@timkpaine
Copy link
Collaborator Author

Let me check, the tests should definitely fail if this was done wrong

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants