Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance types documentation #153

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Enhance types documentation #153

wants to merge 3 commits into from

Conversation

jooola
Copy link
Contributor

@jooola jooola commented May 24, 2021

I struggled trying to find what to write each field. So I searched a bit in the code and the specs.

I think I made some wrong assumptions, so I am open for some improvements.

A few mandatory TODO in the code should be addressed anyway.

@jooola jooola changed the title Enhence types documentation Enhance types documentation May 24, 2021
@jooola
Copy link
Contributor Author

jooola commented May 24, 2021

And I feel some fields could use a new name as it might not always be really clear.

@coveralls
Copy link

coveralls commented May 24, 2021 •
edited

Coverage Status

Coverage remained the same at 99.571% when pulling 4c4a0d2 on jooola:enhance_types_documentation into fd77835 on jpmonette:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jooola @coveralls