Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add footer link, better list styles and GTM scripts #106

Closed
wants to merge 14 commits into from
Closed

Add footer link, better list styles and GTM scripts #106

wants to merge 14 commits into from

Conversation

javisperez
Copy link
Contributor

@javisperez javisperez commented Mar 13, 2024 •
edited

This PR:

  • Improves the spaces for unordered and ordered lists
  • Adds X's logo to the social links in the footer
  • Adds GTM scripts

Preview

image

image

image

@javisperez javisperez self-assigned this Mar 13, 2024
@annigro annigro linked an issue Mar 13, 2024 that may be closed by this pull request
Docs: improve rendering for lists #102
Closed
bmicklea
bmicklea reviewed Mar 13, 2024
View reviewed changes
Copy link
Contributor

@bmicklea bmicklea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only commenting on the visual elements (others should review the code), but it looks good to me. Lists are more readable and the footer looks good too.

@gorkem
Copy link
Contributor

gorkem commented Mar 13, 2024

This needs to be rebased

@javisperez javisperez closed this Mar 13, 2024
@javisperez javisperez deleted the add-tags-manager branch March 13, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmicklea bmicklea bmicklea approved these changes

@gorkem gorkem Awaiting requested review from gorkem

@amisevsk amisevsk Awaiting requested review from amisevsk

@annigro annigro Awaiting requested review from annigro

Assignees

@javisperez javisperez

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs: improve rendering for lists
3 participants
@javisperez @gorkem @bmicklea