Don't set #![deny(warnings)] on the whole crate #1040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deny(warnings) is generally considered to be a pretty strong anti-pattern[0] because new warnings can be introduced, either by new versions of rustc or by new versions of dependencies, that the binary author may want to prevent but shouldn't prevent users from building from source. In this case, a newer version of `chrono` deprecated `NaiveDateTime::from_timestamp`, which ended up breaking my CI pipeline because josh is no longer able to build. Generally, instead, it's better practice to deny *specific* warnings, or build with `-D warnings` in CI. [0]: https://rust-unofficial.github.io/patterns/anti_patterns/deny-warnings.html
Could you please add that? Otherwise CI will start accepting warnings |
|
I ran into that problem myself a while ago. I still don't quite understand why a build breaking warning through a dependency change can happen with all dependencies pinned (including rustc) 🤔 But passing this from the outside via a flag does sound ok to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deny(warnings) is generally considered to be a pretty strong anti-pattern0 because new warnings can be introduced, either by new versions of rustc or by new versions of dependencies, that the binary author may want to prevent but shouldn't prevent users from building from source. In this case, a newer version of
chronodeprecatedNaiveDateTime::from_timestamp, which ended up breaking my CI pipeline because josh is no longer able to build.Generally, instead, it's better practice to deny specific warnings, or build with
-D warningsin CI.