heroku: Uninstall devDependencies after build #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should help reduce the size of the slug. From https://dashboard.heroku.com/apps/reported-web/activity/builds/c343e368-6f2d-454f-97b1-de7c67723b88: ! Warning: Your slug size (307 MB) exceeds our soft limit (300 MB) which may affect boot time. See https://devcenter.heroku.com/changelog-items/1145 and yarnpkg/yarn#696 (comment)
josephfrazier
added a commit
that referenced
this pull request
Oct 1, 2019
This reverts commit a35972b.
josephfrazier
added a commit
that referenced
this pull request
Oct 1, 2019
Reverts #198 It didn't actually help, according to https://dashboard.heroku.com/apps/reported-web/activity/builds/f415ccb0-df01-4339-8d58-ef3c4fa60da3: ! Warning: Your slug size (307 MB) exceeds our soft limit (300 MB) which may affect boot time. This is likely because heroku does it already: https://devcenter.heroku.com/articles/nodejs-support#package-installation This reverts commit a35972b.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should help reduce the size of the slug. From https://dashboard.heroku.com/apps/reported-web/activity/builds/c343e368-6f2d-454f-97b1-de7c67723b88:
See https://devcenter.heroku.com/changelog-items/1145
and yarnpkg/yarn#696 (comment)