-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement support for Toolbar and Context Menu plugins #438
Open
dhughes-xumak
wants to merge
8
commits into
josdejong:develop
Choose a base branch
from
dhughes-xumak:feature/toolbar-and-contextmenu-plugins
base: develop
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Implement support for Toolbar and Context Menu plugins #438
dhughes-xumak
wants to merge
8
commits into
josdejong:develop
from
dhughes-xumak:feature/toolbar-and-contextmenu-plugins
Commits on Jul 18, 2017
-
Configuration menu - View commit details
-
Copy full SHA for eb48486 - Browse repository at this point
Copy the full SHA eb48486View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2a6a65e - Browse repository at this point
Copy the full SHA 2a6a65eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2dd41d7 - Browse repository at this point
Copy the full SHA 2dd41d7View commit details -
Add a selectedElements parameter to ContextMenu to pass to actions' c…
…lick handlers. This allows us to remove the ugly callback wrapping when processing the contextMenuPlugins. Also updates test and documentation.
Configuration menu - View commit details
-
Copy full SHA for a8e3ae9 - Browse repository at this point
Copy the full SHA a8e3ae9View commit details -
Add contextMenuPlugin.submenuTitle to docs and test.
I noticed that the arrow only renders properly in some cases. For this reason, the submenuTitle only works sometimes.
Configuration menu - View commit details
-
Copy full SHA for fbd082d - Browse repository at this point
Copy the full SHA fbd082dView commit details -
Add
contextMenuPlugin.enabled
property so plugins can enable/disabl……e themselves. Includes docs and tests. In the future, it may be preferable for disabled actions to be constructed and appear in the context menu, appearing as disabled (grayed out).
Configuration menu - View commit details
-
Copy full SHA for f33365d - Browse repository at this point
Copy the full SHA f33365dView commit details
Commits on Jul 22, 2017
-
Configuration menu - View commit details
-
Copy full SHA for bde68cf - Browse repository at this point
Copy the full SHA bde68cfView commit details
Commits on Jul 24, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 231ab37 - Browse repository at this point
Copy the full SHA 231ab37View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.