Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Move ext-intl and ext-bcmath out of require and into suggest blo… #188

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pointybeard
Copy link

…ck (closes #187)

Relates to #187

There is existing code to check that ext-intl and ext-bcmath are installed. Including them in the require block of composer.json is too restrictive and does no allow this package to be used on systems without them even though ext-intl is only used for spellout() and SimpleCalculator can be used instead of BinaryCalculator.

This change moves them into the composer suggest block instead, allowing the code to throw exceptions where necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Relax ext-bcmath requirement in composer.json and instead add checks when attempting to use BinaryCalculator
1 participant