Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionally show notebook tag and title on each card #40

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

virtulis
Copy link

@virtulis virtulis commented Jan 4, 2023

Pretty useful to arrange cards across all projects at once.

Not sure if I had to make a separate context and config dialog or if there was a simpler way :)

image

The API docs say "icon" is "text" while it seems to be either a "" or a JSON object, not sure if it can be something else so I put in a try-catch just in case.

@PackElend
Copy link
Collaborator

Thx for the pr 🙂
Can you share a screenshot of the where to set the option?

@virtulis
Copy link
Author

virtulis commented Jan 4, 2023

I added an icon in the top right corner - you'll need to "add" a "rule" in that dialog.

image

Or you can just add it to the display config in markdown, like:

```kanban
filters:
  rootNotebookPath: /
columns:
  - name: Backlog
    backlog: true
  - name: Work in progress
    tag: wip
  - name: Finished
    tag: done
display:
  showNotebookTag: true
```

@PackElend
Copy link
Collaborator

@virtulis we are still searching for a new maintainer but as you familiar (a bit) with the codebase of the plug-in would are ok with checking the other PRs.
I can't call myself experienced enough, but if some of the others would check each other's PRs, it can be said that the code is safe, so I merge it.
At least there would be some progress
thx

@mhelleboid
Copy link
Collaborator

The code works as described, and the test case has passed.

This would be good to modify the main README.md to indicate this feature to users (even if the "eye/display" icon can help)

@mhelleboid
Copy link
Collaborator

This feature is so nice, that maybe it could be activated by default, with an option to desactivate it (instead of the opposite)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants