-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
5.1 inclusion into minor #337
base: master
Are you sure you want to change the base?
Conversation
Modified to include 5.1
Modified to include 5.1
I would say we should also allow updates from 4.4-dev and 5.0-dev to 5.1-dev right? |
can we directly restructure this into understandable directories and file names please |
Include 4.4 in update to 5.1
4.4 move to 5.1
You mean like you did with next.xml for instance? Maybe should be done in a separate PR. |
splitting first makes more sense, to make it clear what should happen |
Using new patch files
Updated to use new major.xml files
Updated to use the new minor.xml files
Removed data used in new minor files
Updated to use the test.xml files
Target Platform 4.0 should point to default.xml
Removed 4.0
Removed 4.0
I have split the files. I was able to spot a few mistakes (at least, I thought they were mistakes...). |
are your spotted mistakes related to 4.0.4 and lower versions? |
In list_test:
did not seem right to me because nothing mentioned in extension_test.xml |
I also make sure 4.0.4 is treated differently:
goes to the default.xml file rather that patch.xml for instance, because we always need to install it first on 4.0 systems before anything else. |
<update> | ||
<name>Joomla! 4.0</name> | ||
<description>Joomla! 4.0 CMS</description> | ||
<element>joomla</element> | ||
<type>file</type> | ||
<version>4.0.4</version> | ||
<infourl title="Joomla 4.0.4 Release">https://www.joomla.org/announcements/release-news/5849-joomla-4-0-4-and-joomla-3-10-3-are-here.html</infourl> | ||
<downloads> | ||
<downloadurl type="full" format="zip">https://downloads.joomla.org/cms/joomla4/4-0-4/Joomla_4.0.4-Stable-Update_Package.zip</downloadurl> | ||
</downloads> | ||
<tags> | ||
<tag>stable</tag> | ||
</tags> | ||
<supported_databases mysql="5.6" mariadb="10.1" postgresql="11.0" /> | ||
<php_minimum>7.2.5</php_minimum> | ||
<maintainer>Joomla! Production Department</maintainer> | ||
<maintainerurl>https://www.joomla.org</maintainerurl> | ||
<section>STS</section> | ||
<targetplatform name="joomla" version="4.0" /> | ||
</update> | ||
<update> | ||
<name>Joomla! 4.4 Nightly Build</name> | ||
<description>Joomla! CMS</description> | ||
<element>joomla</element> | ||
<type>file</type> | ||
<version>4.4.1-dev</version> | ||
<infourl title="Joomla! Nightly Builds">https://developer.joomla.org/nightly-builds.html</infourl> | ||
<downloads> | ||
<downloadurl type="full" format="zip">https://developer.joomla.org/nightlies/Joomla_4.4.1-dev-Development-Update_Package.zip</downloadurl> | ||
</downloads> | ||
<tags> | ||
<tag>stable</tag> | ||
</tags> | ||
<supported_databases mysql="5.6" mariadb="10.1" postgresql="11.0" /> | ||
<php_minimum>7.2.5</php_minimum> | ||
<maintainer>Joomla! Production Department</maintainer> | ||
<maintainerurl>https://www.joomla.org</maintainerurl> | ||
<targetplatform name="joomla" version="4.0.[456]" /> | ||
</update> | ||
<update> | ||
<name>Joomla! 4.4 Nightly Build</name> | ||
<description>Joomla! CMS</description> | ||
<element>joomla</element> | ||
<type>file</type> | ||
<version>4.4.1-dev</version> | ||
<infourl title="Joomla! Nightly Builds">https://developer.joomla.org/nightly-builds.html</infourl> | ||
<downloads> | ||
<downloadurl type="full" format="zip">https://developer.joomla.org/nightlies/Joomla_4.4.1-dev-Development-Update_Package.zip</downloadurl> | ||
</downloads> | ||
<tags> | ||
<tag>stable</tag> | ||
</tags> | ||
<supported_databases mysql="5.6" mariadb="10.1" postgresql="11.0" /> | ||
<php_minimum>7.2.5</php_minimum> | ||
<maintainer>Joomla! Production Department</maintainer> | ||
<maintainerurl>https://www.joomla.org</maintainerurl> | ||
<targetplatform name="joomla" version="4.[1234]" /> | ||
</update> | ||
<update> | ||
<name>Joomla! 5.0 Nightly Build</name> | ||
<description>Joomla! CMS</description> | ||
<element>joomla</element> | ||
<type>file</type> | ||
<version>5.0.1-dev</version> | ||
<infourl title="Joomla! Nightly Builds">https://developer.joomla.org/nightly-builds.html</infourl> | ||
<downloads> | ||
<downloadurl type="full" format="zip">https://developer.joomla.org/nightlies/Joomla_5.0.1-dev-Development-Update_Package.zip</downloadurl> | ||
</downloads> | ||
<tags> | ||
<tag>stable</tag> | ||
</tags> | ||
<supported_databases mysql="8.0.13" mariadb="10.4" postgresql="12.0" /> | ||
<php_minimum>8.1.0</php_minimum> | ||
<maintainer>Joomla! Production Department</maintainer> | ||
<maintainerurl>https://www.joomla.org</maintainerurl> | ||
<targetplatform name="joomla" version="5.[0]" /> | ||
</update> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you removed the special handling for 4.0.x series at least I'm not sure what you are doing with it?
did you changed it to j4/default.xml?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, all handling of 4.0 is done in j4/default.xml
No description provided.