Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not generating URLs with "limitstart=0" #4393

Closed
wants to merge 3 commits into from
Closed

Not generating URLs with "limitstart=0" #4393

wants to merge 3 commits into from

Commits on Sep 29, 2014

  1. Not generating URLs with "limitstart=0" 

    Instead of removing the "limitstart" parameter in the router file (see joomla#3725 ), we do not generate URLs with "limitstart=0".
Kind of weird to add it there to be then removed in the router, isn't it?

So components will be able to use the parameter "limitstart=0" if they want to... and we still avoid the duplicate url issue we used to have.
Sounds like a win / win! :)
    @hikashop-jerome
    hikashop-jerome committed Sep 29, 2014
    Copy the full SHA
    cf19227 View commit details
    Browse the repository at this point in the history

  2. Allow the parameter "limitstart=0" 

    With the patch joomla#4393 we also modify the router in order to accept this parameter.
So components which want to use it for resetting the pagination, still can.
    @hikashop-jerome
    hikashop-jerome committed Sep 29, 2014
    Copy the full SHA
    efecb94 View commit details
    Browse the repository at this point in the history

  3. Update site.php

    @hikashop-jerome
    hikashop-jerome committed Sep 29, 2014
    Copy the full SHA
    7db31ca View commit details
    Browse the repository at this point in the history