Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.1] Fix TinyMCE media button, insert link bug #43374

Open
wants to merge 2 commits into
base: 5.1-dev
Choose a base branch
from

Conversation

Fedik
Copy link
Member

@Fedik Fedik commented Apr 26, 2024

Pull Request for Issue #43365

Summary of Changes

Fix inserting PDF in to TinyMCE as a link

Testing Instructions

Run npm install
In TinyMCE editor try to insert a PDF file, using Media button

Actual result BEFORE applying this Pull Request

Nothing hapen.
Browser console shows an error

Expected result AFTER applying this Pull Request

Link inserted

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:
  • No documentation changes for docs.joomla.org needed
  • Pull Request link for manual.joomla.org:
  • No documentation changes for manual.joomla.org needed

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.1-dev labels Apr 26, 2024
@Fedik Fedik linked an issue Apr 26, 2024 that may be closed by this pull request
@Fedik Fedik added the bug label Apr 26, 2024
@Quy
Copy link
Contributor

Quy commented Apr 26, 2024

I have tested this item ✅ successfully on 6339fe1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43374.

1 similar comment
@carlitorweb
Copy link
Member

I have tested this item ✅ successfully on 6339fe1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43374.

@Quy
Copy link
Contributor

Quy commented Apr 27, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43374.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.1-dev RTC This Pull Request is Ready To Commit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[5.1] TinyMCE: can't insert media in article
4 participants