Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.4] Contact VCF: Properly assign value to array #43353

Merged
merged 6 commits into from May 6, 2024

Conversation

Hackwar
Copy link
Member

@Hackwar Hackwar commented Apr 24, 2024

Summary of Changes

While going through the code with phpstan, this showed up as error. Instead of assigning the string to a new entry in the array, we are also trying to read from this array by trying to concatenate a string... I'm struggling to explain it, but if you look at the code, you see the problem. Right now this does not throw an error in PHP, but it is just a matter of time when PHP becomes strict enough to complain about this.

Testing Instructions

Codereview

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

Copy link
Member

@HLeithner HLeithner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code review

@Quy
Copy link
Contributor

Quy commented Apr 25, 2024

I have tested this item ✅ successfully on 59e7346


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43353.

@Quy
Copy link
Contributor

Quy commented Apr 28, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43353.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Apr 28, 2024
@richard67 richard67 added the bug label May 5, 2024
@MacJoom MacJoom self-assigned this May 6, 2024
@MacJoom MacJoom added this to the Joomla! 4.4.5 milestone May 6, 2024
@MacJoom MacJoom merged commit 5f8305f into joomla:4.4-dev May 6, 2024
3 checks passed
@MacJoom
Copy link
Contributor

MacJoom commented May 6, 2024

Thank you!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants