[5.2] Fixing timezone and language parameter in API token auth response #43351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@brianteeman what's the issue? |
|
Missing documentation |
|
What documentation are you expecting? |
laoneo
reviewed
May 3, 2024
| @@ -247,8 +247,8 @@ public function onUserAuthenticate(AuthenticationEvent $event): void | |||
| $response->username = $user->username; | |||
| $response->email = $user->email; | |||
| $response->fullname = $user->name; | |||
| $response->timezone = $user->get('timezone'); | |||
| $response->language = $user->get('language'); | |||
| $response->timezone = $user->getParam('timezone', $this->getApplication()->get('offset', 'GMT')); | |||
There was a problem hiding this comment.
Should it not be UTC instead of GMT?
There was a problem hiding this comment.
We use both UTC and GMT. In com_users MethodsModel and in libraries FeedDocument we use UTC and in the user class we use GMT.
There was a problem hiding this comment.
In the global Joomla configuration we use UTC, so I would stick to it. But it is a minor issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
In the token API authentication plugin we are constructing a response with the timezone and language from the user object. However, that data is stored in the params and to get that, you have to call getParam() and not just get(). The later is the ->get from CMSObject and doesn't return anything in this instance.
Testing Instructions
Codereview
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed