Issue with navigation menu #37926 #40259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joomla-cms-bot
added
NPM Resource Changed
|
I think you forgot to commit your changes. |
Actually I haven't done any changes, just change my branch from 4.3 to 4.4 because in previous PR I have the branch 4.3 while doing pull request |
Co-authored-by: Quy <quy@fluxbb.org>
Signed-off-by: Olivier Buisard <olivier.buisard@simplifyyourweb.com>
…sts" and checked out Guided Tours module when updating from 4.2.9 or older (#40286)
|
This here is accidentally used as upmerge pr, but I did the upmerge from 4.3 manually. Just a fyi. |
Kostelano
added a commit
to JPathRu/localisation
that referenced
this pull request
Sep 4, 2023
* Новое в Joomla 4.4.0 Alpha 4 joomla/joomla-cms#40071 + joomla/joomla-cms#40259 - (вероятно, ошибка при обновлении ветки автора) joomla/joomla-cms#40466 + joomla/joomla-cms#40469 + joomla/joomla-cms#40493 + joomla/joomla-cms#40510 + joomla/joomla-cms#40534 + joomla/joomla-cms#40533 + joomla/joomla-cms#40565 + joomla/joomla-cms#41024 + joomla/joomla-cms#40774 + joomla/joomla-cms#41099 + joomla/joomla-cms#41379 +
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #37926
Issue with navigation menu and breakpoints
Clean installation of joomla 4.1.4 without any changes.
I noticed that on screens with resolutions between 768px (medium) and 992px (large), the navigation menu does not collapse to hamburger menu.
so i have change the bootstrap class it will automatically turn into a hamburger menu at smaller screen
related to #37926
Summary of Changes
After changing the class now the nav is responsive
Actual result BEFORE applying this Pull Request
No hamburger menu is created
Expected result AFTER applying this Pull Request
Automatically hamburger menu will created when screen size is reduced
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed