Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.1] TinyMCE: can't insert media in article #43365

Closed
drmenzelit opened this issue Apr 25, 2024 · 3 comments · May be fixed by #43374
Closed

[5.1] TinyMCE: can't insert media in article #43365

drmenzelit opened this issue Apr 25, 2024 · 3 comments · May be fixed by #43374
Labels
bug No Code Attached Yet

Comments

@drmenzelit
Copy link
Contributor

Steps to reproduce the issue

In an article try to insert a PDF file (CMS Content -> Media)

Expected result

You can insert a link to or you get an iframe with the PDF

Actual result

Javascript error, insert button doesn't work for download PDF. Iframe seems to be inserted, after saving the article, the iframe dissapears

grafik

System information (as much as possible)

Joomla 5.1
PHP 8.1.28 / 8.2.18
MySQL 8.0.35 / MariaDB 10.6.15

Additional comments
@brianteeman
Copy link
Contributor

Confirm the error with the download
No problem with the insert, it produces an object which is saved without error
image

@Quy Quy added the bug label Apr 25, 2024
@Fedik
Copy link
Member

Fedik commented Apr 25, 2024

This need to be relaced to editorInst.getSelection()

joomla-cms/build/media_source/system/js/fields/joomla-media-select.w-c.es6.js

Line 243 in fc51f46

} else if (Joomla.editors.instances[editor].getSelection() !== '') {

I will make PR, later

@Fedik Fedik mentioned this issue Apr 26, 2024
Open
4 tasks
@Fedik
Copy link
Member

Fedik commented Apr 26, 2024

Please test #43374

@Fedik Fedik closed this as completed Apr 26, 2024
@Fedik Fedik linked a pull request Apr 26, 2024 that will close this issue
[5.1] Fix TinyMCE media button, insert link bug #43374
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug No Code Attached Yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[5.1] Fix TinyMCE media button, insert link bug Fedik/joomla-cms
5 participants
@Quy @brianteeman @Fedik @drmenzelit @joomla-cms-bot