small bugs and allow transform #28
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
replaced 'start', 'stop' with the new 'windowOn', 'windowOff'
Not suficiently tested, ugly way to pass the settings around, but it should prove the formula validity.
This reverts commit c43945b.
This reverts commit aa3ba8c.
Also express wR and hR as a scale usable in transform.
This reverts commit 6f42d46.
change meaning of wR, hR to that of a scale usable in transforms
refactored for easier merge
This was referenced Sep 22, 2014
Closed
note that there are some IOS platform issues with transform of videos. It's more stable when using transform=false.
- disable transform for videos - do not slow down finding the image. (assumption is there are more pictures than videos)
correct bad branch merge
This reverts commit 9481f37.
This reverts commit 606faf1.
This reverts commit 9567f69.
merged all patches
sligtly modified from the jquery repository to match jshint 2.5.6 features
|
Could you have just one branch with all your changes please? I'm working on #46 & would like to see what I can work in what you have, but can't follow 3 branches at once 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following your request: a simplified pull request
patches to apply are a1b6347 3d20804 d88bc12 d739dc0 85a9d1e