Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] Fix LinearAlgebra.lmul! on GPU #233

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Conversation

vpuri3
Copy link
Contributor

@vpuri3 vpuri3 commented Nov 1, 2023

fix #232

@vpuri3
Copy link
Contributor Author

vpuri3 commented Nov 3, 2023

maybe we should rather use GPUArrays.generic_lmul! here

@vpuri3 vpuri3 changed the title Fix LinearAlgebra.lmul! on GPU [wip] Fix LinearAlgebra.lmul! on GPU Dec 24, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jan 1, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (971a222) 73.99% compared to head (8b2ca50) 73.89%.

Files Patch % Lines
src/linear_algebra.jl 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #233      +/-   ##
==========================================
- Coverage   73.99%   73.89%   -0.10%     
==========================================
  Files          23       23              
  Lines         746      747       +1     
==========================================
  Hits          552      552              
- Misses        194      195       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lmul! fails with Component Array on GPU
2 participants