Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redshift-gtk: use Ayatana AppIndicator3 instead of App Indicator3 #757

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kenhys
Copy link

@kenhys kenhys commented Apr 27, 2020

libappindicator was deprecated and it will be removed in the
future Debian release.

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=895037

There is a successor API compatible library - Ayatana Indicator.

https://ayatanaindicators.github.io/code/

libappindicator was deprecated and it will be removed in the
future Debian release.

  https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=895037

There is a successor API compatible library - Ayatana Indicator.

  https://ayatanaindicators.github.io/code/
@CameronNemo
Copy link
Contributor

Thanks for the patch. Does this affect any existing distros which might ship the older library but not the newer one? If so, is there a way to keep compatibility with both?

@kenhys
Copy link
Author

kenhys commented May 4, 2020

Here are current status of Ayatana Appindicator:

Debian 9(old-stable): not available
Debian 10(stable): available
Ubuntu 16.04(xenial): not available
Ubuntu 18.04(bionic): available
Ubuntu 19.10(eoan): available
Ubuntu 20.04(focal): available

It is ok to migrate Ayatana because it is available on stable release.

If you want to keep compatibility with both, it may better to try (Ayatana Appindicator) and fallback to AppIndicator .

@jonls
Copy link
Owner

jonls commented Jun 14, 2020

Yeah it seems like it should be easy to try Ayatana first then fallback to the old import since the APIs are supposedly compatible?

@jonls jonls self-requested a review June 14, 2020 02:50
Copy link
Owner

@jonls jonls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Fallback to old module.
  • Some of the documentation mentions appindicator which should be updated I think.
  • Needs a rebase on master to fix CI issues.

@hartwork
Copy link

@kenhys applied in Gentoo at gentoo/gentoo@08e2652 , thanks for the patch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants