fix disable resetting color+temp continuously #719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To reproduce without this patch:
1. run `./src/redshift -v` in a terminal
2. in another terminal, `pkill -USR1 redshift`
... which ought to disable its processing altogether, once completed
... but doesn't :(
3. while it's disabled, manually set the brightness:
`xrandr --output HDMI2 --brightness 0.5`
4. after a few seconds (default is 5secs between iterations), the
brightness (and temp) jumps up again despite redshift being disabled
With this patch, instead - the resetting of colour and temperature is
done only once after the program's been disabled, and subsequent changes
of brightness or temperature etc. via a separate `xrandr` while the
program is disabled have the desired effect (i.e. they stick instead of
being reset by a "disabled" redshift program).
Once the program is re-enabled again (i.e. via another `pkill -USR1
redshift`), the program is again allowed to make changes to brightness
and temperature, as it ought to be able to.
|
Hope to see this merged soon. It currently makes it hard to control the brightness of an external screen with e.g. |
CameronNemo
reviewed
Jul 26, 2020
| @@ -685,6 +686,7 @@ run_continual_mode(const location_provider_t *provider, | |||
| if (verbose && disabled != prev_disabled) { | |||
There was a problem hiding this comment.
This conditional is wrong, see https://gitlab.com/chinstrap/gammastep/-/issues/2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To reproduce without this patch:
./src/redshift -vin a terminalpkill -USR1 redshift... which ought to disable its processing altogether, once completed
... but doesn't :(
xrandr --output HDMI2 --brightness 0.5brightness (and temp) jumps up again despite redshift being disabled
With this patch, instead - the resetting of colour and temperature is
done only once after the program's been disabled, and subsequent changes
of brightness or temperature etc. via a separate
xrandrwhile theprogram is disabled have the desired effect (i.e. they stick instead of
being reset by a "disabled" redshift program).
Once the program is re-enabled again (i.e. via another
pkill -USR1 redshift), the program is again allowed to make changes to brightnessand temperature, as it ought to be able to.