Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VASTAds Constructor fix for new Chrome #20

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

VASTAds Constructor fix for new Chrome #20

wants to merge 2 commits into from

Conversation

Fire-Brand
Copy link

As discussed in issue #19 this fixes the getElementsByTagNameNS call with root.namespaceURI to call it with "*" .

@jonhoo
Copy link
Owner

jonhoo commented Oct 19, 2015

Could you please split this into two PRs -- one for each feature? I'm happy to merge both.

@Fire-Brand
Copy link
Author

I remember only sending one PR, the second one was just a commit, don't know why it popped up in this PR.

I'm not sure how to resend as 2 separate PRs, advice?

@jonhoo
Copy link
Owner

jonhoo commented Oct 20, 2015

It's because you made this change after already having committed your AdParameter fix. PRs include all commits that differ from master. Assuming origin points to your fork, and upstream points to this repo (see git remote -v), to create separate PRs, try:

git checkout -b pr1 upstream/master
git cherry-pick 3142292e65642b9c469e13b460ce7d6c950d319d
git push -u origin pr1
git branch -D pr1
git checkout -b p2 upstream/master
git cherry-pick 933d3fa0d49302114159c88d0c410cee8773894c
git push -u origin pr2
git branch -D pr2

You should now have two new branches in your fork: pr1 and pr2. Create a PR for each one, and they should only include the appropriate commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants