Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to inject custom calendar with backward compatibility #392

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nitinkraghuwanshi
Copy link

Issue :
I needed to update few calendar's property e.g. firstWeekday, because JTDateHelper was returning non mutable calendar object , i was not able to do so.

Solution proposing
As JTDateHelper is having three instance variable , NSCalendar, NSLocale and NSTimeZone, but only 2 are available to inject.
There can always be a need to update some properties of NSCalendar and hence I added ability to inject full calendar object itself with maintaining the backward compatibility of current code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants