New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#3] Fix shim script to launch correct version #4
Conversation
bin/install
Outdated
|
||
ls "${ASDF_INSTALL_PATH}/exe" | while read file; do | ||
cat "${ASDF_INSTALL_PATH}/exe/${file}" | \ | ||
sed -E "s|#!/usr/bin/env ruby|#!/usr/bin/env -S RUBYLIB=${ASDF_INSTALL_PATH}/lib ruby|" > \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sed in place instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Can we add some regression tests? (even just the examples you listed above) |
Do you happen to know why the existing test suite didn't find this issue already? I see that you are using |
I'm having this issue as well - the default bundler with ruby ends up getting used. Using this branch fixes it. What would it take to move forward on this? |
Ah, CI is not passing yet! asdf-vm/asdf#1078 needs to be merged upstream :) |
Before:
After: