V1.0 review fixes #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it more comfortable to use the API and reduces a lot of casting.
Since this is a "core" API it belongs togheter with other similar API:s
The final call might block while finishing up an async update.
To reduce casting everywhere
To reduce casting everywhere
This also clarifies the get_last/first_block API's. Namely that they return the lba's of the underlying storage device.
Otherwise it provides a pretty limited range for 32-bit platforms.
Partitions sizes are exposed through the BIO layer anyway.
This should only be used in memory allocation situations
SZ_MB -> SZ_MiB SZ_kB -> SZ_KiB SZ_GB -> SZ_GiB
Since punchboot these days actually uses the extcsd to report the correct size of boot partitions we need a way to be backwards compatible with existing systems. This option allows the user to override the boot partition size to something less than the physical size. Most users should leave this disabled.
jonasblixt
force-pushed
the
v1.0-review-fixes
branch
from
5b1e81f
to
46a3dcd
Compare
Codecov Report
@@ Coverage Diff @@
## master #22 +/- ##
==========================================
- Coverage 68.39% 68.06% -0.33%
==========================================
Files 54 54
Lines 2781 2784 +3
==========================================
- Hits 1902 1895 -7
- Misses 879 889 +10
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.