This repository has been archived by the owner on May 18, 2022. It is now read-only.
reply to LL_VERSION_IND once per connection #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello ! 馃
This PR is for issue #49 .
(relevant to Version Exchange procedure section of bluetooth 5.2 core specs)
I added a
boolmember toConnectionthat keeps track ofwhether we had previously sent a Control PDU
LL_VERSION_INDfor the connection.I also added a new variant
VersionIndSentto enumLlcpError.It is also mentioned in #49 that eventually we want to collapse all bool state variables to a single byte as bitflags,
but I didn't make that change in this PR. So I guess the issue should be kept open?
Thank you for reviewing this PR ! 馃憤