Skip to content
This repository has been archived by the owner on May 18, 2022. It is now read-only.

Only reply to LL_VERSION_IND once #49

Open
jonas-schievink opened this issue Apr 23, 2019 · 0 comments
Open

Only reply to LL_VERSION_IND once #49

jonas-schievink opened this issue Apr 23, 2019 · 0 comments
Labels
area: link layer Code Area: BLE Link Layer (establishing and maintaining connections, encryption, etc) good first issue Call for participation: Good for newcomers status: needs code An implementation or a bugfix need to be written type: bug Something isn't behaving as intended

Comments

@jonas-schievink
Copy link
Owner

Either master or slave may send the LL_VERSION_IND LL Control PDU, and both will respond to it. According to the spec, you're supposed to keep track of whether you've already sent this and ignore the PDU in that case. We currently rely on the master to implement this correctly, since we'd otherwise end up in an endless loop.

To fix this, we need to add another bool to the real-time LinkLayer state to track whether we've sent this already. Eventually we should collapse all the bool flags into a single byte storing them as bitflags.

@jonas-schievink jonas-schievink added type: bug Something isn't behaving as intended status: needs code An implementation or a bugfix need to be written area: link layer Code Area: BLE Link Layer (establishing and maintaining connections, encryption, etc) labels Apr 23, 2019
@jonas-schievink jonas-schievink added the good first issue Call for participation: Good for newcomers label Nov 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: link layer Code Area: BLE Link Layer (establishing and maintaining connections, encryption, etc) good first issue Call for participation: Good for newcomers status: needs code An implementation or a bugfix need to be written type: bug Something isn't behaving as intended
Projects
None yet
Development

No branches or pull requests

1 participant