Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding only_noneros argument to coef() #15

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

kushagragpt99
Copy link

Adding the argument 'only_nonzeros' to coef() to print only nonzero coefficients. GSoC 2021 task for the project 'Adding Adaptive Bayesian SLOPE (ABSLOPE) to the SLOPE Package'.

@kushagragpt99
Copy link
Author

Checks related to rebuilding the vignette from introduction.Rmd have failed, I'm not sure if changes made to coef.R might have affected that.

@jolars
Copy link
Owner

jolars commented Mar 23, 2021

Checks related to rebuilding the vignette from introduction.Rmd have failed, I'm not sure if changes made to coef.R might have affected that.

Probably. The problem is that you've made the only_nonzeros argument TRUE by default, so it'll have all kinds of unexpected consequences for tests and examples in the package, since coef() is used in several places.

@kushagragpt99
Copy link
Author

Yep, thanks a lot for pointing that out. I have made the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants