Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pip install -r requirements.txt – fails on fresh install #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

darylantony
Copy link

because pip hasn't installed django yet, which is referenced by the django_faker/__init__.py

adding setup_requires as an 'abstract' dependency in addition to install_requires, as according to the documentation:

"...projects listed in setup_requires will NOT be automatically installed on the system where the setup script is being run. They are simply downloaded to the setup directory if they’re not locally available already. If you want them to be installed, as well as being available when the setup script is run, you should add them to install_requires and setup_requires..."

unfortunately, I'm not sure this will work because of the separation or responsibilities between pip and setuptools.

because pip hasn't installed django yet, which is referenced by the django_faker/__init__.py

adding setup_requires as an 'abstract' dependency in addition to install_requires, as according to the documentation:

"...projects listed in setup_requires will NOT be automatically installed on the system where the setup script is being run. They are simply downloaded to the setup directory if they’re not locally available already. If you want them to be installed, as well as being available when the setup script is run, you should add them to install_requires and setup_requires..."

unfortunately, I don't expect this to work because of the separation or responsibilities between pip and setuptools.

We need to be able to tell pip to complete the installation of django completely, before carrying out django-faker
@rosscdh
Copy link

rosscdh commented May 10, 2018

+1 also submitted a PR fixing same issue #29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants